Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background opacity in menus; improving accessibility/readability #15847

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

artfulrobot
Copy link
Contributor

Overview

Civi's menu is 90% opaque for some reason, presumably a stylistic decision. It makes it hard to read the menu items. This fixes that by making the menu opaque.

I found it hard to read and the idea of going opaque seemed to suit at least some others
https://chat.civicrm.org/civicrm/pl/cp98ne1isjbrtx41rgh936fejw

Before

before-DT

After

Screenshot from 2019-11-14 16-47-26-DT

@civibot
Copy link

civibot bot commented Nov 14, 2019

(Standard links)

@civibot civibot bot added the master label Nov 14, 2019
CRM/Core/Resources.php Outdated Show resolved Hide resolved
@colemanw
Copy link
Member

Personally I thought the opacity was a nice touch. But if people hate it, ok we can do away with it.

@artfulrobot
Copy link
Contributor Author

Thanks, @colemanw

I think if it would be fine if combined with a background blur so the text on top was still easy to read. My eyes aren't terrible but I have found it hard enough times to warrant this PR.

@mlutfy
Copy link
Member

mlutfy commented Nov 15, 2019

👍 I didn't want to bike-shed on the menu, but I've been patching it on our installs. (my eyes aren't very good and generally favour high contrast)

@artfulrobot
Copy link
Contributor Author

Seems quite a lot of support for this.

TBH, I never had a problem when it was black 90% opaque. I suspect this is to do with the fact that our eyes are more sensitive to varations in bright colours than in dark colours.

@totten
Copy link
Member

totten commented Nov 15, 2019

<bike-shed-data-point>I don't hate the transparency, and I do think it looks prettier to glance at, but it is harder for me to read, so soft +1 on tweaks to improve readability.</bike-shed-data-point>

@mlutfy
Copy link
Member

mlutfy commented Nov 22, 2019

I think there is sufficient consensus to merge this?

@colemanw colemanw merged commit b2f8d6f into civicrm:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants