[REF] XMLProcessor/Report - Extract method to make it more testable #15838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I want to write a test for this but currently I'd have to compare against the full output html.
Technical Details
The way github displays this is a little weird but all I did was pull out everything in getCaseReport except the last two lines and put it into a new function _getCaseReport, and then call that from getCaseReport. I find it easier to see if you click the expandy icons near the line numbers on the left so that you can see it without a break in the middle.
Comments
I can't include the test yet in this PR because it fails for two reasons, one of which is what I was originally looking to fix, and the other is coming next.