Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] XMLProcessor/Report - Extract method to make it more testable #15838

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

demeritcowboy
Copy link
Contributor

Overview

I want to write a test for this but currently I'd have to compare against the full output html.

Technical Details

The way github displays this is a little weird but all I did was pull out everything in getCaseReport except the last two lines and put it into a new function _getCaseReport, and then call that from getCaseReport. I find it easier to see if you click the expandy icons near the line numbers on the left so that you can see it without a break in the middle.

Comments

I can't include the test yet in this PR because it fails for two reasons, one of which is what I was originally looking to fix, and the other is coming next.

@civibot
Copy link

civibot bot commented Nov 13, 2019

(Standard links)

@civibot civibot bot added the master label Nov 13, 2019
@totten totten changed the title [NFC] pull section out to make more testable [REF] pull section out to make more testable Nov 13, 2019
@totten totten changed the title [REF] pull section out to make more testable [REF] XMLProcessor/Report - Extract method to make it more testable Nov 13, 2019
@demeritcowboy
Copy link
Contributor Author

I think test fail is unrelated but jenkins retest this please.

@eileenmcnaughton eileenmcnaughton merged commit 554bfe5 into civicrm:master Nov 14, 2019
@demeritcowboy demeritcowboy deleted the getcasereport-split branch November 14, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants