Fix CRM/Event/BAO/AdditionalPaymentTest.php to use Order.create #15813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
c22441c to
9156d03
Compare
This test wasn't really testing much since the functions were kinda contorted into doing what the test was testing. I've updated it to do set up using Order.create & not to use the 'partial_amount_to_pay' keys which turn out not to create valid transactions (& which we want to fully remove from the other places). I had to co-erce tax_amount into a float in a couple of places & shortened a param for readability. I commented out a couple of checks that only worked because of unrealisitic function calls I added https://lab.civicrm.org/dev/financial/issues/102 to track that.
9156d03 to
ac823f4
Compare
mattwire
reviewed
Nov 14, 2019
| if ($previousLineItems[$updateFinancialItemInfoValues['entity_id']]['tax_amount']) { | ||
| $updateFinancialItemInfoValues['tax']['amount'] = $lineItemsToUpdate[$updateFinancialItemInfoValues['entity_id']]['tax_amount'] - $previousLineItems[$updateFinancialItemInfoValues['entity_id']]['tax_amount']; | ||
| if ($previousLineItem['tax_amount'] | ||
| && $previousLineItems[$updateFinancialItemInfoValues['entity_id']]['tax_amount'] !== 0.00) { |
There was a problem hiding this comment.
@eileenmcnaughton Do these 0.00 comparisons work? As a float the value would be 0.0, as a string it could be "0.00"
There was a problem hiding this comment.
I added them because the tests failed without them - it's casting to float now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test wasn't really testing much since the functions were kinda contorted into doing what the
test was testing. I've updated it to do set up using Order.create & not to use the 'partial_amount_to_pay'
keys which turn out not to create valid transactions (& which we want to fully remove from the other places).
I had to co-erce tax_amount into a float in a couple of places & shortened a param for readability.
I commented out a couple of checks that only worked because of unrealisitic function calls
I added https://lab.civicrm.org/dev/financial/issues/102 to track that.
Overview
A brief description of the pull request. Try to keep it non-technical.
Before
The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
After
What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
Technical Details
If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary
Comments
Anything else you would like the reviewer to note