Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] declare thrown exceptions #15809

Merged
merged 1 commit into from
Nov 11, 2019
Merged

[NFC] declare thrown exceptions #15809

merged 1 commit into from
Nov 11, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Tidy up on test class

Before

After

Technical Details

Mostly this is declaring exceptions. I also removed a tearDown after class as the tearDown already does as much & more. It would be good to use tearDownAfterClass more but this is not a case of us doing that properly

Comments

@civibot
Copy link

civibot bot commented Nov 11, 2019

(Standard links)

@civibot civibot bot added the master label Nov 11, 2019
@seamuslee001
Copy link
Contributor

Agree with the changes

@seamuslee001 seamuslee001 merged commit a08dfa9 into civicrm:master Nov 11, 2019
@seamuslee001 seamuslee001 deleted the except branch November 11, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001