dev/core#183 Use Standard CRM_Utils_SQL_TempTable builder to create temporary tabl…

[seamuslee001]

…e in Campaign and upgrade

Overview

This converts the creation of temporary tables in CRM/Campaign and CRM/Upgrade to be standardised through the CRM_Utils_SQL_TempTable interface

Before

Uses the deprecated CRM_Core_DAO::createTempTableName function to generate a temporary table name

After

Uses the standard CRM_Utils_SQL_TempTable functionality

ping @monishdeb @eileenmcnaughton @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Hmm - I can take the upgrade ones on faith based on upgrade tests but I found the other borked

[eileenmcnaughton]

We should probably wrap those fns in some sort of unit test..

[seamuslee001]

@eileenmcnaughton have just pushed a fix for that malformed category thing

[seamuslee001]

@eileenmcnaughton i have added a unit test for the change in CRM/Campaign/BAO/Query.php but i'm not sure how i would be able to generate one for the Interview change

[eileenmcnaughton]

I was able to reserve & interview without fatal error & it passed through these lines - gtg