dev/mailing#56 dev/mailing#57 Ensure that we don't pass in any namesp…

[seamuslee001]

…aced fields when building the row array for mailing reports

Overview

Following the datepicker conversion for some mailing smart groups, some mailing job fields started to be name spaced which then lead to e-notices of undefined property as per dev/mailing#57 and mailing reports showing incorrect information dev/mailing#56

This resolves it by using the name key for the fields as that will be the non unique / non name spaced version

Before

unique field name used causing e-notices

After

non unique field name used

ping @eileenmcnaughton @totten @demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I tested this on the Australian Greens dev and confirmed the issue as per the screenshot below

After applying the patch the report looked correct

[eileenmcnaughton]

This makes sense but feels kinda hacky - any chance you could follow up with a test against master?

Adding MOP