Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dompdf (0.8.0=>0.8.3) & dependencies #15739

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Update dompdf

Before

Supposedly the package combo doesn't even support php 7.x!

After

Php 7.3 does not hit errors on the DomPDF package

Technical Details

DomPDF issues warnings on php 7.3
The latest version boasts 'Improved compatibility with PHP 7.3'
https://github.com/dompdf/dompdf/releases/tag/v0.8.3

To get there I needed to do
composer update dompdf/dompdf phenx/php-svg-lib sabberworm/php-css-parser

& also got https://github.com/sabberworm/PHP-CSS-Parser/releases
onto the version that supports php 7+ - no obvious issues in the release notes and

https://github.com/PhenX/php-svg-lib/releases

  • moving us from Bruised Bumblebee to Fanatical Furet

Once againt nothing alarming & improved php 7+ support

Comments

DomPDF issues warnings on php 7.3
The latest version boasts 'Improved compatibility with PHP 7.3'
https://github.com/dompdf/dompdf/releases/tag/v0.8.3

To get there I needed to do
composer   update dompdf/dompdf phenx/php-svg-lib sabberworm/php-css-parser

& also got https://github.com/sabberworm/PHP-CSS-Parser/releases
onto the version that supports php 7+ - no obvious issues in the release notes  and

https://github.com/PhenX/php-svg-lib/releases
- moving us from Bruised Bumblebee to Fanatical Furet

Once againt nothing alarming & improved php 7+ support
@civibot
Copy link

civibot bot commented Nov 6, 2019

(Standard links)

@civibot civibot bot added the master label Nov 6, 2019
@totten totten changed the title Update dompdf & dependencies Update dompdf (0.8.0=>0.8.3) & dependencies Nov 7, 2019
@seamuslee001
Copy link
Contributor

As discussed in product maintenance merging now that the 5.20 RC has been cut

@seamuslee001 seamuslee001 merged commit 970e69b into civicrm:master Nov 7, 2019
@seamuslee001 seamuslee001 deleted the dompdf branch November 7, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants