Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php 7.3 fix - don't mis-use continue #15737

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Php 7.3 fix - don't mis-use continue #15737

merged 1 commit into from
Nov 5, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Php 7.3 gives warnings if you use continue where you should use break

Before

Warnings

After

Poof

Technical Details

Also fix some casing

Comments

@civibot
Copy link

civibot bot commented Nov 5, 2019

(Standard links)

@civibot civibot bot added the master label Nov 5, 2019
@eileenmcnaughton eileenmcnaughton merged commit 3256970 into civicrm:master Nov 5, 2019
@eileenmcnaughton eileenmcnaughton deleted the php73 branch November 5, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001