Add test to lock in obscure custom join handling #15715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Nov 4, 2019
| @@ -108,7 +113,7 @@ public function testSearchCustomDataDateFromTo() { | |||
|
|
|||
| $params[$dateCustomField['id']] = CRM_Contact_BAO_Query::convertFormValues($formValues); | |||
| $queryObj = new CRM_Core_BAO_CustomQuery($params); | |||
| $queryObj->Query(); | |||
| $queryObj->query(); | |||
There was a problem hiding this comment.
correction of case to match fn
715a437 to
53266d2
Compare
53266d2 to
0e1544e
Compare
|
Only affects tests and Jenkins is happen then i am too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit test preliminary to cleaning up the CustomQuery join handling
Before
Search builder custom address field scenario untested
After
Tested
Technical Details
Some tweaks to test helper class - will have to see if this upsets any existing tests as it tweaks the identifiers
Comments