dev/event#19 remove obsolete scriptFee & scriptArray #15679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://lab.civicrm.org/dev/event/issues/19#note_25984 Both @mattwire & myself determined these are obsolete, unused parameters, removing
|
(Standard links)
|
|
test this please |
3 similar comments
|
test this please |
|
test this please |
|
test this please |
|
@eileenmcnaughton looks right and confirm that variables are obsolete. |
|
thanks @yashodha good to have less cruft causing confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes unused parameters scriptFee & scriptArray
https://lab.civicrm.org/dev/event/issues/19#note_25984
Before
They exist
After
Unicorns are real
Technical Details
Both @mattwire & myself determined these are obsolete, unused parameters, removing
Comments