Add uniquenames for mailing_name, mailing_job_status #15652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in support of civicrm#15369 Where the names in the search do not match the 'real names' we have 2 techniques 1) where adding a unique name to the schema gives a match we do that - here that is the case for mailing_name 2) otherwise we ensure the schema has a unique name if appropriate & rename the field in the upgrade scriptt In this case when we look at CRM_Mailing_BAO_Query we don't see mailing_name as present (only mailing_id which should be an entity reference field). However it is used in the confusingly-not-related Mailing search so lets rename this one at the same time.
|
(Standard links)
|
|
Looks right to me merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unique names to the schema for mailing_name & mailing_job_status. Affects advanced search code quality. Otherwise OK
Before
No uniquenames
After
Uniquenames
Technical Details
This is in support of #15369
Where the names in the search do not match the 'real names' we have 2 techniques
the case for mailing_name
rename the field in the upgrade script
In this case when we look at CRM_Mailing_BAO_Query we don't see mailing_name
as present (only mailing_id which should be an entity reference field). However it
is used in the confusingly-not-related Mailing search so lets rename this
one at the same time.
Comments