Improve metadata support for table civicrm_mailing_job in search #15634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This makes the civicrm_mailing_job_start_date field available as metadata and cleans up the code specifying how civicrm_mailing_job gets joined in. It turns out the code design has a pretty sensible methodology for ensuring that required tables are added but unaware of this the tables got configured all over the place in the where clause functions.
fb0802d to
0a71a7f
Compare
|
Changes look good to me and tested in conjunction with #15633 and happy with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes no change in itself but tidies up the Mailing BAO object to prepare for the datepicker change @seamuslee001 has been working on
Before
Less stdised - needs more funky handling
After
More standardised
Technical Details
This makes the civicrm_mailing_job_start_date field available as
metadata and cleans up the code specifying how
civicrm_mailing_job gets joined in.
It turns out the code design has a pretty sensible methodology for ensuring that required
tables are added but unaware of this the tables
got configured all over the place in the where clause
functions.
Comments