Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#560 [REF] Throw exceptions for invalid type errors when aborting #15623

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Oct 27, 2019

Overview

Throw an exception if we are aborting for Type of param error

Before

Deprecated CRM_Core_Error::fatal triggered

After

Exception is triggered

https://lab.civicrm.org/dev/core/issues/560

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Oct 27, 2019

(Standard links)

@civibot civibot bot added the master label Oct 27, 2019
@eileenmcnaughton eileenmcnaughton changed the title [REF] Throw exceptions for invalid type errors when aborting dev/core#560 [REF] Throw exceptions for invalid type errors when aborting Oct 27, 2019
@eileenmcnaughton
Copy link
Contributor

As discussed we have been removing fatal calls for a long time now without any issues. This one is a bit more central but there is also no legit reason for working code to hit it - let's do it

@seamuslee001 seamuslee001 merged commit a393333 into civicrm:master Oct 27, 2019
@seamuslee001 seamuslee001 deleted the type_check_exceptions branch October 27, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants