PayPal: Add SOLUTIONTYPE parameter that triggers allowing to pay without having to create an account #15523
Conversation
Add SOLUTIONTYPE parameter that triggers allowing to pay without having to create a paypal account. Without this parameter, PayPal account creation is required to complete a transaction. I can think of no reason why anyone would want to default to requiring account creation for a PayPal checkout unless they were actually a marketer at PayPal.
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
Jenkins add to whitelist |
|
Thoughts please @eileenmcnaughton @kcristiano @Stoob Change seems sensible but there's always the risk of introducing some random error when we change paypal! |
|
@jamie-tillman The change looks sensible. I tested using PayPal Standard. I tested without the patch and I could pay without an account. I tested with and could also pay without an account. Using OmniPay PayPal Check i could not reproduce the issue. Do you have steps to reproduce? Does this only happen with a specific configuration? |
|
@kcristiano that seems like an endorsement to merge - ie fixes without an account & doesn't break with |
|
@eileenmcnaughton I agree This does not break existing functionality. I'd have preferred to replicate the issue, but it does seem safe to merge. |
|
I've had difficulty figuring out just what constitutes PayPal "standard" vs. anything else. The PayPal site and documentation is confusing. It appears that the site I'm having difficulty with is using PayPal Express Checkout and the PayPal Express Checkout payment processor in Civi. Does this help? I could probably give you a link to a payment page that would demonstrate the issue and one that does not, since we have a live and test site. |
|
I don't think the PaymentExpress Checkout code supports not having an account - it definitely doesn't use this code & you do have to generate an api key |
Interestingly enough, I'm using the code I committed in production, and it's working just fine, and has been for months. The only reason it stopped was that I performed an update which wiped out my hack. We are using the Username/Password/Signature combination. Not sure what you mean by API Key. I'm unfortunately not familiar with these PayPal options. PayPal appears to have deprecated these payment terms you're using more than 2 years ago and I'm still struggling to figure out how it applies to a current PayPal account. |
|
I just had to manually correct this problem on another site post-upgrade. Is there any interest in fixing the problem, or should I withdraw my pull request and just fork the project so I can ensure I don't keep getting bitten by this bug? |
|
Merging based on the review by @kcristiano and code review. Thanks for the patch @jamie-tillman ! (I also did a bit of reading on stack overflow, which seems to confirm the fix) |
Add SOLUTIONTYPE parameter that triggers allowing to pay without having to create a paypal account.
Overview
Adds a single parameter to the checkout values. Without this parameter, PayPal account creation is required to complete a transaction. I can think of no reason why anyone would want to default to requiring account creation for a PayPal checkout unless they were actually a marketer at PayPal.