Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] minor extraction with code to build dedupe arrays #15519

Merged
merged 1 commit into from
Oct 16, 2019
Merged

[REF] minor extraction with code to build dedupe arrays #15519

merged 1 commit into from
Oct 16, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 16, 2019 •
edited
Loading

Overview

Minor readability extraction

Before

Code is hideously awful

After

Still hideously awful but marginal improvement

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 16, 2019

(Standard links)

@civibot civibot bot added the master label Oct 16, 2019
@seamuslee001
Copy link
Contributor

I worked through this extraction and agree with it, Merging

@seamuslee001 seamuslee001 merged commit 58e7f00 into civicrm:master Oct 16, 2019
@seamuslee001 seamuslee001 deleted the dedupe branch October 16, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001