Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/financial#69 Fix misrecording of payments against non pay_later Pending contribution. #15511

Merged
merged 1 commit into from
Oct 15, 2019
Merged

dev/financial#69 Fix misrecording of payments against non pay_later Pending contribution. #15511

merged 1 commit into from
Oct 15, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton
dev/financial#69 Fix misrecording of payments against non pay_later P…
2930e4a 
…ending contribution.

Fixes bugs when payments are added against a non-pay later contribution. There were 2 different bugs
1) bug in form layer when the payment is fully paid
2) bug in BAO layer for partial payments.

This fixes both. It may be a regression, hence 5.19
@civibot civibot bot added the 5.18 label Oct 15, 2019
@civibot
Copy link

civibot bot commented Oct 15, 2019

(Standard links)

@seamuslee001 seamuslee001 merged commit c330d0b into civicrm:5.18 Oct 15, 2019
@seamuslee001 seamuslee001 deleted the 518 branch October 15, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001