Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] dev/core#1046 - minor consistency change #15486

Merged
merged 1 commit into from
Oct 16, 2019
Merged

[NFC] dev/core#1046 - minor consistency change #15486

merged 1 commit into from
Oct 16, 2019

Conversation

demeritcowboy
Copy link
Contributor

Overview

Doesn't change anything, just removes some inconsistency in variable naming and will make a bigger PR smaller.

@civibot
Copy link

civibot bot commented Oct 11, 2019

(Standard links)

@civibot civibot bot added the master label Oct 11, 2019
@demeritcowboy demeritcowboy mentioned this pull request Oct 11, 2019
Merged
@alifrumin
Copy link
Contributor

@demeritcowboy I can review this next week.

@demeritcowboy
Copy link
Contributor Author

Thanks @alifrumin !

@alifrumin
Copy link
Contributor

@eileenmcnaughton this change just moves from using the variable name displaylabel to displayLabel

It is a non functional change that improves consistency I believe this is ready to be merged.

@mattwire
Copy link
Contributor

Merging based on @alifrumin review

@mattwire mattwire merged commit 22fe60e into civicrm:master Oct 16, 2019
@demeritcowboy demeritcowboy deleted the displaylabel-vs-displayLabel branch October 18, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master sig:code maintenance readability testability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demeritcowboy @alifrumin @mattwire @eileenmcnaughton