Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] move definition of important values & retrieval outside payment… #15458

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 9, 2019

Overview

Very small code cleanup

Before

Code less readable

After

The squirrels ate my code

Technical Details

The concepts of billingMode is deprecated - goal is not to have separate handling for each one

Comments

There are some payment processor related issues in this code but it's ruthlessly mind bending so we need to feed a few squirrels first

…-object 'if' clauses

The concepts of billingMode is deprecated - goal is not to have separate handling for each one
@civibot
Copy link

civibot bot commented Oct 9, 2019

(Standard links)

@civibot civibot bot added the master label Oct 9, 2019
@eileenmcnaughton
Copy link
Contributor Author

@mattwire are you ok to merge this - it's just part of trying to get rid of the isNotify loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants