dev/core#1293 Ensure that the filtering for empty addresses is proper… #15429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly wrapped up so that the ORs don't cause wrong contacts to be exported
|
(Standard links)
|
|
closing in favour of #15439 as cleaner and has a unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly wrapped up so that the ORs don't cause wrong contacts to be exported
Overview
The or in the filtering fo street addresses was not properly wrapped causing wrong contacts to be exported
Before
Wrong contacts are exported
After
Correct contacts exported
ping @eileenmcnaughton @demeritcowboy