dev/core#1281 fix e-notice on isLiveMode

[eileenmcnaughton]

Overview

Fixes a recent regression which appears to be an unintended change of functionality in 5.15
For replication - from ticket.

"Also in order to notice any missing functionality you'd have to have the setting at admin - system settings - misc - record generated letters set to "one combined activity plus one attachment", which isn't the default."

Before

Enotice seen , combined attachment code ignored

After

Prior behaviour restored

Technical Details

Looks like a regression from 752cee4
which hit in 5.15 - seems good to merge to rc / about to cut to rc

Comments

@demeritcowboy thanks for spotting this - ideally we should get this one out

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 let's merge this before branching (since we are still waiting). It's a candidate for 5.18

[eileenmcnaughton]

test fail unrelated

[seamuslee001]

Looks fine to me MOP

[demeritcowboy]

Gave it a spin. Tried print/merge document with and without the admin setting changed. Looks good - no notices and it functions as expected.