Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] don't handle non-array, pass by reference #15413

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Pretty trivial cleanup

Before

Squirrels dancing

After

Squirrels more subdued

Technical Details

This is only called from one place & it is definitely coming in as an array & using the return values.

Comments

This is only called from one place & it is definitely coming in as an array & using the return values.
@civibot
Copy link

civibot bot commented Oct 7, 2019

(Standard links)

@civibot civibot bot added the master label Oct 7, 2019
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Oct 7, 2019

One of my squirrels tells me this is "eek ch ch ee eek". I have no idea what that means since I don't speak squirrel but agree with the technical detail assessment above.

I did a couple simple tests of the form and seems good.

Since I assumed this was related to other work involving force=1, I did one test with that (with sort_name), and it sets the form field value. It doesn't return the right results but it didn't before either.

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 does that count as a solid review?

@seamuslee001
Copy link
Contributor

Makes sense merging as per @demeritcowboy 's review

@seamuslee001 seamuslee001 merged commit 47ddcc9 into civicrm:master Oct 7, 2019
@seamuslee001 seamuslee001 deleted the default_sub_type branch October 7, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants