Remove Print Icon

[alifrumin]

Overview

Removes the print icon from the upper left hand corner of all pages because printing the page nearly always looks better then printing by clicking the print icon.

Before

Printer icon in the upper left corner of all pages

After

No printer icon

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[vingle]

Have opened a GL issue to discus this. Ping to @smaen123 - in case you want to add to it.

[vingle]

Hi @alifrumin - have chatted with @eileenmcnaughton and it sounds like there's three steps to get this merged. At the sprint there should be enough support to lift needs-concept approval, but before we see if someone can review the code, is there a reason it's still a WIP?

[alifrumin]

Hey @vingle! I started this at a sprint and then completely forgot about it. I'm glad you guys have taken an interest in it. I will remove the WIP tag.

[eileenmcnaughton]

As part of review - let's check if this makes https://lab.civicrm.org/dev/core/issues/1224 better or worse (since it DOES require css for printing - which might be removed here)

[vingle]

test this please

[vingle]

(CiviCRM Review Template DEL-1.2)

• General standards

  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
  • User impact (r-user)
    • PASS: The change would be intuitive majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: We checked the icon was no longer visible on key screens. We checked you can still print rows from search. We checked print summary action still works from contact

• Developer standards

  • Technical impact (r-tech)

    • UNREVIEWED

  • Code quality (r-code)

    • UNREVIEWED

  • Maintainability (r-maint)

    • UNREVIEWED

  • Test results (r-test)

    • PASS: The test results are all-clear.

[mattwire]

test fails unrelated

[eileenmcnaughton]

Developer review portion of the review (@vingle )

• Developer standards

  • Technical impact (r-tech)

    • PASS I've gone through the code and am comfortable that this only removes the print icon and the code that supports inserting & rendering it - and not any of the php that makes various print related functions work. I'm comfortable this won't impact other aspects.

  • Code quality (r-code)

    • PASS no new code introduced

  • Maintainability (r-maint)
    * PASS no new code introduced

[eileenmcnaughton]

Thanks @alifrumin @vingle @mattwire - this appears to be something many people agree on based on sprint discussions