Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporting-20: don't display soft credits by default when force=1 #15315

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

MegaphoneJon
Copy link
Contributor

@MegaphoneJon MegaphoneJon commented Sep 16, 2019

https://lab.civicrm.org/dev/report/issues/20

Overview

When you load the Contribution Detail report with force=1 it shows soft credits by default. Without force=1, the default is to NOT show soft credits. This sets the force=1 default in line with the more common use case.

Before

$params['contributions_or_soft_credits'] being undefined means "show soft credits".

After

$params['contributions_or_soft_credits'] being undefined means "don't show soft credits".

Technical Details

The issue is that this piece of code assumes contributions_or_soft_credits is always defined, and the report defaults to contributions_only. However, this param isn't defined when force=1.

Steps to replicate are on the ticket: https://lab.civicrm.org/dev/report/issues/20

@civibot
Copy link

civibot bot commented Sep 16, 2019

(Standard links)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants