reporting-20: don't display soft credits by default when force=1 #15315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lab.civicrm.org/dev/report/issues/20
Overview
When you load the Contribution Detail report with
force=1
it shows soft credits by default. Without force=1, the default is to NOT show soft credits. This sets theforce=1
default in line with the more common use case.Before
$params['contributions_or_soft_credits']
being undefined means "show soft credits".After
$params['contributions_or_soft_credits']
being undefined means "don't show soft credits".Technical Details
The issue is that this piece of code assumes
contributions_or_soft_credits
is always defined, and the report defaults tocontributions_only
. However, this param isn't defined whenforce=1
.Steps to replicate are on the ticket: https://lab.civicrm.org/dev/report/issues/20