Restrict inactive Dashlet query to Dashlets in the current domain

[christianwach]

Overview

Link to the issue on Lab. Ongoing fixes for the CiviCRM Dashboard when using multiple Domains.

Before

When a Contact has a Dashboard in more than one domain, adding a Dashlet to their Dashboard disables all unused Dashlets in all Domains. This resets their Dashboards on other Domains such that they show no active Dashlets at all.

After

When a Contact has a Dashboard in more than one domain, adding a Dashlet to their Dashboard will disable only unused Dashlets in the current Domain. This preserves the Dashlets on the Dashboards on other Domains.

Technical Details

Restricts the query that disables inactive Dashlets to those in the current Domain.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

nicely done @christianwach

[christianwach]

@seamuslee001 FWIW, I notice that most of the queries in CRM_Core_BAO_Dashboard are not parameterised (if that's actually a word!) but I assume that's because this file hasn't had any attention for several years.

[seamuslee001]

@christianwach I think your right there

[christianwach]

@seamuslee001 Thanks!