Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure filtering on email via the api looks for an exact match #15276

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 11, 2019

Overview

Fixes a released regression whereby a wildcard was being added to api Contact.get requests with the email parameter

Before

  civicrm_api3('Contact', 'get', ['email' => 'bob@'];

Would return a contact with email 'bob@example.com'

After

Only exact matches returned

Technical Details

Wildcards are being added in the query object. We are most of the way now to converting them correctly at the form layer & deprecating that handling but is a little more conservative for the rc

Comments

@civibot
Copy link

civibot bot commented Sep 11, 2019

(Standard links)

@civibot civibot bot added the master label Sep 11, 2019
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.18 September 11, 2019 01:49
@civibot civibot bot added 5.18 and removed master labels Sep 11, 2019
@eileenmcnaughton eileenmcnaughton changed the title Email2 Ensure filtering on email via the api looks for an exact match Sep 11, 2019
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this one too

@seamuslee001
Copy link
Contributor

I'm ok with this as i think if someone wants to do a LIKE query they can specify it in the API adding MOP

@eileenmcnaughton eileenmcnaughton merged commit 91ae8b4 into civicrm:5.18 Sep 11, 2019
@eileenmcnaughton eileenmcnaughton deleted the email2 branch September 11, 2019 03:07
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Jan 7, 2020
civicrm#15276

Change-Id: Ifd684580ca31dc9c43763bf90806bc16786f7f10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants