Remove is_public flag from report paths #15261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though these paths are publicly accessible, they are not intended as 'public' paths
|
(Standard links)
|
|
@JKingsnorth yes 5.18 please |
|
@eileenmcnaughton OK I've updated the base branch on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though these paths are publicly accessible (access callback is just TRUE), they are not intended as 'public' paths really. They still provide administrative functionality, and are not intended for end users of the site.
Having them with the is_public flag causes the report list and report pages to show up in the 'public' website theme, rather than the admin theme, which is a UI regression as identified by @jensschuppe in #14945 (comment)
Pinging @eileenmcnaughton and @seamuslee001 as they were also involved in the review of the original PR.
If this is considered a regression then I can put it on another branch rather than master if needed.