Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] array formatting: #15250

Merged
merged 1 commit into from
Sep 9, 2019
Merged

[NFC] array formatting: #15250

merged 1 commit into from
Sep 9, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

formatting only

Before

array()

After

[]

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 8, 2019

(Standard links)

@civibot civibot bot added the master label Sep 8, 2019
@seamuslee001
Copy link
Contributor

@eileenmcnaughton the style police officer has logged on https://test.civicrm.org/job/CiviCRM-Core-PR/28820/checkstyleResult/new/

@eileenmcnaughton
Copy link
Contributor Author

OK fixed - I fixed some places where strict comparison was appropriate (for form not function) https://github.com/civicrm/civicrm-core/pull/15250/files#diff-c5e39924ad99ac88b48763a0d8fa246eR168

@colemanw
Copy link
Member

colemanw commented Sep 9, 2019

Looks good.

@eileenmcnaughton eileenmcnaughton merged commit e130ce9 into civicrm:master Sep 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the nfc branch September 9, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw