Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1230 Permission nuancing, fix another place where merge duplicate contacts should be enough #15227

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Gives contacts with ''merge duplicate contacts'' permission to get dedupe rules

Before

'Administer CiviCRM' required

After

'Administer CiviCRM' or 'merge duplicate contacts' required

Technical Details

Per the example in the comment block on CRM_Core_Permission::check()

   * Ex 3: Must have 'access CiviCRM' or 'access Ajax API'
   *   [
   *     ['access CiviCRM', 'access Ajax API'],
   *   ],

It seems fine for Rule.create & delete to require administer CiviCRM but merge duplicate contacts should be enough for get

Comments

…icate contacts should be enough

It seems fine for Rule.create & delete to require administer CiviCRM but merge duplicate contacts should be enough for get
@civibot
Copy link

civibot bot commented Sep 6, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

makes sense MOP

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 2434aaf into civicrm:master Sep 6, 2019
@eileenmcnaughton eileenmcnaughton deleted the dedupe branch September 6, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants