Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to civicrm_contact.created_date & modified_date #15203

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Adds index on civicrm_contact.created_date & modified_date to speed up searches that access those fields

Before

Unindexed

After

Indexed on new installs or installs that have run the upgrade script

Technical Details

Comments

Note this will add the indexes to new installs or to installs who run the script to update indexes
(we used to promote this via a status check but there was a bug & we 'hushed' it & stopped trying to fix
the bug)

@civibot
Copy link

civibot bot commented Sep 3, 2019

(Standard links)

@civibot civibot bot added the master label Sep 3, 2019
@totten
Copy link
Member

totten commented Sep 3, 2019

Seems like a sensible change. 👍

@MegaphoneJon
Copy link
Contributor

If I apply this as a patch to 5.17 and run System.updateindexes I assume there won't be any repercussions on upgrade to 5.18, because it's not part of the normal upgrade script?

@eileenmcnaughton
Copy link
Contributor Author

That's correct

@seamuslee001
Copy link
Contributor

@eileenmcnaughton this now has a conflict can you rebase?

Note this will add the indexes to new installs or to installs who run the script to update indexes
(we used to promote this via a status check but there was a bug & we 'hushed' it & stopped trying to fix
the bug)
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 done

@seamuslee001
Copy link
Contributor

Test fail unrelated

@seamuslee001 seamuslee001 merged commit 2941451 into civicrm:master Sep 4, 2019
@seamuslee001 seamuslee001 deleted the index_contact branch September 4, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants