Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#1226) Fix regression where new groups created on 5.16 with relative dates save 'fixed dates' #15201

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 3, 2019

Overview

FIxes a regression whereby creating new groups on 5.16 with a relative date on one of the below fields say it saved as a fixed date (e.g 'this.month' ended up as '_low' => '2019-09-01', _high => '2019-09-30')

It is not possible to repair these but we can prevent more being created.

  'log_date_relative',
  'pledge_payment_date_relative',
  'pledge_start_date_relative',
  'pledge_end_date_relative',
  'pledge_create_date_relative',
  'member_join_date_relative',
  'member_start_date_relative',
  'member_end_date_relative',
  'birth_date_relative',
  'deceased_date_relative',
  'mailing_date_relative',
  'relation_date_relative',
  'relation_start_date_relative',
  'relation_end_date_relative',
  'relation_action_date_relative',
  'contribution_recur_start_date_relative',
  'contribution_recur_next_sched_contribution_date_relative',
  'contribution_recur_cancel_date_relative',
  'contribution_recur_end_date_relative',
  'contribution_recur_create_date_relative',
  'contribution_recur_modified_date_relative',
  'contribution_recur_failure_retry_date_relative',

Before

Some groups created on civi 5.16 will not retain relative date information

After

Above is fixed

Technical Details

In the medium term all of these will be standardised as datepicker fields

Comments

This is a slightly modified backport of #15194

@civibot
Copy link

civibot bot commented Sep 3, 2019

(Standard links)

@totten
Copy link
Member

totten commented Sep 3, 2019

Updated description to provide link to related PR.

@totten totten changed the title Fix regression where new groups created on 5.16 with relative dates save 'fixed dates' (dev/core#1226) Fix regression where new groups created on 5.16 with relative dates save 'fixed dates' Sep 3, 2019
@seamuslee001
Copy link
Contributor

Test fail unrelated

@seamuslee001 seamuslee001 merged commit 0a1dd08 into civicrm:5.16 Sep 3, 2019
@seamuslee001 seamuslee001 deleted the 516 branch September 3, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants