Use metadata for pledgeDateRange fields #15191

eileenmcnaughton · 2019-09-02T12:54:20Z

Overview

Minor code cleanup - introduce a function to cleanup further code

Repetitive lines with only metadata different

Metadata used. IN addition the metadata should be translated whereas the ts() was omitted in prior code

This moves the date handling for date fields to a re-usable function

civibot · 2019-09-02T12:54:22Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

seamuslee001 · 2019-09-02T20:54:51Z

(CiviCRM Review Template WORD-1.2)

General standards
- (r-explain) Pass
- (r-user) Pass
- (r-doc) Pass
- (r-run) Pass I did some query testing on the PR test site and all looks correct to me
Developer standards
- (r-tech) Pass
- (r-code) Pass
- (r-maint) Pass
- (r-test) Pass

eileenmcnaughton · 2019-09-02T20:59:49Z

Use metadata for pledgeDateRange fields

33a17d7

This moves the date handling for date fields to a re-usable function

civibot bot added the master label Sep 2, 2019

eileenmcnaughton mentioned this pull request Sep 2, 2019

[Date picker][REF] Convert jcalendar date fields to date picker on me… #15177

Merged

seamuslee001 merged commit 57682f5 into civicrm:master Sep 2, 2019

seamuslee001 deleted the pledge_high_low branch September 2, 2019 20:55