Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1230 Dedupe permissions - allow safe mode merging based on 'merge duplicate contacts' #15188

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 2, 2019

Overview

Perhaps batch mode merge contacts to users with 'merge duplicate contacts' (not just administer CiviCRM as before). Adds a check for 'force merge duplicate contacts' if mode is aggressive

Before

Administer CiviCRM permission required to access Job.process_batch_merge

After

'merge duplicate contacts' required to access Job.process_batch_merge but in aggressive mode
'force merge duplicate contacts' is required

Technical Details

This is probably the first attempt to use these api to build access for users with less than Administer CiviCRM -hence all the things that have emerged

Comments

https://lab.civicrm.org/dev/core/issues/1230

@civibot
Copy link

civibot bot commented Sep 2, 2019

(Standard links)

…e contacts'

Ensure force merge permission for force merging (not at the api layer as api v4 won't use that
@eileenmcnaughton eileenmcnaughton changed the title Dedupe permissions - allow safe mode merging based on 'merge duplicate contacts' dev/core#1230 Dedupe permissions - allow safe mode merging based on 'merge duplicate contacts' Sep 3, 2019
@seamuslee001
Copy link
Contributor

Permission level makes sense to me here and seems to be adequately backed up by unit tests

@seamuslee001 seamuslee001 merged commit d5f4469 into civicrm:master Sep 5, 2019
@seamuslee001 seamuslee001 deleted the dedupe12 branch September 5, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants