Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pledge XML to support date picker conversion #15180

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Update Pledge XML to support date picker conversion #15180

merged 1 commit into from
Sep 1, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

This is a split off from #15170 to update the xml to support the date picker conversion

Before
ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Sep 1, 2019

(Standard links)

@civibot civibot bot added the master label Sep 1, 2019
@eileenmcnaughton eileenmcnaughton changed the title [NFC] Update Pledge XML to support date picker conversion Update Pledge XML to support date picker conversion Sep 1, 2019
@eileenmcnaughton
Copy link
Contributor

I removed NFC because these can have impacts but I think we are good here

@seamuslee001
[NFC] Update Pledge XML to support date picker conversion
a5e468f 
Update unit tests to match new schema
@colemanw
Copy link
Member

colemanw commented Sep 1, 2019

Unrelated fail

@colemanw colemanw merged commit cdf5091 into civicrm:master Sep 1, 2019
@seamuslee001 seamuslee001 deleted the pledge_xml_changes branch September 1, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @colemanw