Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about testRenewMembership failing on certain days #15167

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

mattwire
Copy link
Contributor

Overview

As noted by jenkins - let's add a comment so the next person updating code might find it.

Before

After

Technical Details

Comments

@colemanw

@civibot
Copy link

civibot bot commented Aug 30, 2019

(Standard links)

@civibot civibot bot added the master label Aug 30, 2019
@colemanw
Copy link
Member

Formatting of that comment looks fine to me but jenkins doesn't agree :(

@colemanw
Copy link
Member

Also the test was failing yesterday but seems to be passing today, so I guess the problem date was the 29th.

@mattwire mattwire force-pushed the testRenewMembership_note branch from 887f0f1 to e51c515 Compare August 30, 2019 17:10
@seamuslee001
Copy link
Contributor

Merging thanks @mattwire

@seamuslee001 seamuslee001 merged commit c199a32 into civicrm:master Aug 30, 2019
@mattwire mattwire deleted the testRenewMembership_note branch September 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants