Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP help text and URL are misleading to Organization Address and Contact Info instead of leading to From Email Addresses; see also #14055 and #14329 #15165

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

fkohrt
Copy link
Contributor

@fkohrt fkohrt commented Aug 29, 2019

Overview

This is about a help message that is being displayed when testing the SMTP configuration fails. It says the Email in the Organization Contact Information should be changed. This is wrong however as it appears because of wrongly configured from address.

Before

Text and link point to Organization Address and Contact Info

After

Text and link point to From Email Addresses

Technical Details

none

Comments

Issue explained in erroneous pull request #14055, related lab issue dev/core#879 should be closed

…tact Info instead of leading to From Email Addresses; see also #14055 and #14329
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot civibot bot added the master label Aug 29, 2019
@civibot
Copy link

civibot bot commented Aug 29, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

add to whitelist

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Test fail unrelated this is correct to me merging

@seamuslee001 seamuslee001 merged commit 50520c1 into civicrm:master Sep 4, 2019
@seamuslee001
Copy link
Contributor

@agh1 can you make sure this contributor gets added to the contrib key please

@agh1
Copy link
Contributor

agh1 commented Sep 4, 2019

@seamuslee001 yeah @alifrumin and I catch all the code authors who are missing from the key. The only time we need manual attention is if someone does a lot of work, you make a reviewer's cut of it, and that gets merged instead of the original commits. Or similarly if someone does a lot of review work on one PR, but then that gets closed in favor of another one. We see all the commits that appear in the git log of the RC branch, but that's all we see.

BTW welcome @fkohrt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants