Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded ID for Head of Household relationship #15123

Conversation

mattwire
Copy link
Contributor

Overview

As identified by @demeritcowboy in #15103 which needs merge first.

Before

Hardcoded ID which isn't always the correct ID.

After

ID which is always the correct ID.

Technical Details

We dont have pseudoconstant on relationshiptype so using API getvalue.

Comments

Ping @demeritcowboy

@civibot
Copy link

civibot bot commented Aug 23, 2019

(Standard links)

@demeritcowboy
Copy link
Contributor

Just noting I probably won't be the best tester for this because the main (maybe only?) use of the primary_contact field seems to be during batch membership/contribution entry. Fixing this might cause some things to come up there.

@eileenmcnaughton
Copy link
Contributor

@mattwire the only is merged so this gets a rebase?

@mattwire mattwire force-pushed the fixhardcodedheadofhouseholdrelationship branch from 494664a to eabf1c2 Compare August 23, 2019 20:27
@eileenmcnaughton
Copy link
Contributor

I think this is correct

@eileenmcnaughton eileenmcnaughton merged commit f5c715a into civicrm:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants