Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for PR 15103 #15121

Merged
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

Adds test demonstrating before and after for #15103. This will fail before that PR is merged.

@civibot
Copy link

civibot bot commented Aug 23, 2019

(Standard links)

@demeritcowboy
Copy link
Contributor Author

I can see from the console log it's failed before the merge as expected:

not ok 254 - Error: CRM_Contact_BAO_RelationshipTest::testBAOAdd

So no point waiting for it to finish. Now that the other PR is merged jenkins can you test this please.

@demeritcowboy
Copy link
Contributor Author

Interesting - it finished the previous test anyway, and the newer one is still running just doesn't show it on the PR here yet (https://test.civicrm.org/job/CiviCRM-Core-PR/28513/). Will wait and see if it updates here by itself. For reference here's the full pre-merge fail output:

CRM_Contact_BAO_RelationshipTest::testBAOAdd
Undefined index: contact_id_a

/home/jenkins/bknix-dfl/build/core-15121-6rown/web/sites/all/modules/civicrm/CRM/Contact/BAO/Relationship.php:2272
/home/jenkins/bknix-dfl/build/core-15121-6rown/web/sites/all/modules/civicrm/CRM/Contact/BAO/Relationship.php:313
/home/jenkins/bknix-dfl/build/core-15121-6rown/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/BAO/RelationshipTest.php:316

@eileenmcnaughton eileenmcnaughton merged commit 79f7016 into civicrm:master Aug 23, 2019
@demeritcowboy demeritcowboy deleted the test-bao-relationship branch August 26, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants