Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong variable in check for profiles on contributionpage #15093

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

mattwire
Copy link
Contributor

Overview

Copy/paste error means we're checking an undefined variable.

Before

Undefined variable being checked for preProfile types.

After

Correct variable being checked for preProfile types.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 21, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Yeah I can see last time it was commented but not fixed. Sometimes fixing broken things can cause unintended circumstances (I generally favour removing over fixing in the absence of a bug report). However, I guess pre profiles work for normal submissions just not related contact ones so it seems 'safe to fix'

@eileenmcnaughton eileenmcnaughton merged commit abbff8f into civicrm:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants