Fix recursion in crmInArray()

[christianwach]

Overview

See the issue on Lab.

Before

Recursion does not take place as expected.

After

Recursion takes place as expected.

Technical Details

There's a minor error in CRM_Utils_Array::crmInArray() where the method is called with crmInArray() instead of with self::crmInArray().

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This function appears to be only used in 2 places. Did you encounter this error at runtime? If the function has been broken this long, maybe we can just get rid of it.

[christianwach]

@colemanw That decision is way above my pay grade - I just fixed it :)

[colemanw]

Happy to merge the fix as it's obviously an improvement. But @christianwach I'm still curious to know if you encountered an error at runtime and if so what steps are needed to reproduce.

[christianwach]

@colemanw Nope, not at runtime -- was just poking around in CRM_Utils_Array and spotted it. I too couldn't find an example of passing a nested array to crmInArray but hey. Thanks for merging!