(dev/drupal#79) CRM_Upgrade_Form - Raise MINIMUM_PHP_VERSION from 5.6 to 7.0 #15082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 7.0
This version requirement officially went up to PHP 7.0 circa Civi 5.14.
However, at that time, the upgrade metadata was kept at PHP 5.6 to allow somewhat
softer landing for stragglers. That's no longer possible in 5.16+, so this
just updates the requirement.
Before
------
When upgrading via drush to Civi 5.16+ on PHP 5.6, the Civi class-loader fails to initialize.
```
Parse error: syntax error, unexpected ':', expecting '{' in /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/league/csv/src/functions.php on line 33
```
(Approximate call-path: `civicrm.drush.inc` => `civicrm.settings.php` =>
`CRM_Core_ClassLoader` => `vendor/autoload.php` => `vendor/league/csv/src/functions.php`)
After
-----
It still fails, but at least the metadata is accurate.
There will be a separate patch in another repo to make `drush` use this
metadata and present a better error.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version requirement officially went up to PHP 7.0 circa Civi 5.14. However, at that time, the upgrade metadata was kept at PHP 5.6 to allow somewhat softer landing for stragglers. That's no longer possible in 5.16+, so this just updates the requirement.
Before
When upgrading via drush or Drupal web UI to Civi 5.16+ on PHP 5.6, the Civi class-loader fails to initialize.
(Approximate call-path:
civicrm.drush.inc | civicrm.module=>civicrm.settings.php=>CRM_Core_ClassLoader=>vendor/autoload.php=>vendor/league/csv/src/functions.php)After
It still fails, but at least the metadata is accurate.
There will be a separate PR for
civicrm-drupal.gitto use this metadata and present a clearer error-message.