Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1186 add in unit test to lock in fix from dmeritcowboy in #1… #15058

Merged
merged 1 commit into from
Aug 17, 2019
Merged

dev/core#1186 add in unit test to lock in fix from dmeritcowboy in #1… #15058

merged 1 commit into from
Aug 17, 2019

Conversation

seamuslee001
Copy link
Contributor

…5055

Overview

This adds a unit test proving the issue and locking in the fix by @demeritcowboy

Before

no unit test

After

unit test

ping @eileenmcnaughton @demeritcowboy @mattwire

@civibot
Copy link

civibot bot commented Aug 17, 2019

(Standard links)

@civibot civibot bot added the 5.17 label Aug 17, 2019
@seamuslee001 seamuslee001 mentioned this pull request Aug 17, 2019
Merged
@demeritcowboy
Copy link
Contributor

Thanks!

@seamuslee001
Copy link
Contributor Author

Test failure shows the issue

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit a77cc5a into civicrm:5.17 Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.17 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @demeritcowboy @eileenmcnaughton