Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Demonstrate the truthiness of CRM_Utils_System::isNull #15027

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

demeritcowboy
Copy link
Contributor

Overview

I'm not suggesting to change anything since it's been around since 1.x. This is just based on a footnote from https://lab.civicrm.org/dev/core/issues/937#note_17036 and I couldn't find any tests for it.

Technical Details

I can add some details if required, but the test seems self-explanatory.

@civibot
Copy link

civibot bot commented Aug 13, 2019

(Standard links)

@civibot civibot bot added the master label Aug 13, 2019
@colemanw
Copy link
Member

The function is so screwy it should probably be marked @deprecated.
Php already has isset() which IMO is the preferable way to test if a variable is either null or undefined.

@colemanw colemanw merged commit 2708677 into civicrm:master Aug 13, 2019
@demeritcowboy demeritcowboy deleted the is-nullish branch August 14, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants