Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REPORT] Allow extensions to join address, email and phone tables without limi… #14941

Merged

Conversation

seamuslee001
Copy link
Contributor

…ting to primary fields

Overview

This allows reports to join the address email and phone tables without limiting to just primary fields and add a test to ensure that we don't change current practice

Before

Only join avaliable is on primary address or primary phone or primary email

After

Test and allow for returning of non primary phones and emails and addresses

ping @eileenmcnaughton @mattwire

@civibot
Copy link

civibot bot commented Aug 1, 2019

(Standard links)

@civibot civibot bot added the master label Aug 1, 2019
@seamuslee001 seamuslee001 force-pushed the allow_non_primary_join_reports branch 2 times, most recently from f20106e to 455bdaf Compare August 1, 2019 07:00
@eileenmcnaughton
Copy link
Contributor

OK - this should be 'no change' for existing callers of these functions - so seems fine

@seamuslee001 seamuslee001 force-pushed the allow_non_primary_join_reports branch from f6493dc to ea39e22 Compare August 1, 2019 10:03
@eileenmcnaughton eileenmcnaughton merged commit 01ee968 into civicrm:master Aug 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the allow_non_primary_join_reports branch August 1, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants