Revert "[REF] use generic loadStandardSearchOptionsFromUrl". Fix search selections. #14929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch selections. Overview ------------------- This reverts commit a5ca2ad and fixes a bug in management of the prev/next cache. The bug is visible when following this procedure: 1. In browser, use "Quick search" to search for text "am" 2. In browser, select checkboxes next to two items 3. In MySQL CLI, run `select * from civicrm_prevnext_cache where is_selected =1;` 4. In browser, continue to next page. Observe that there are no more selection. 5. In MySQL CLI, re-run SQL query. Observe that the selections have disappeared. Before ------------------- Proceeding to another page of search results causes loss of selections After ------------------- Selections are preserved
|
(Standard links)
|
|
added MOP |
|
unrelated fails - if we drop a 5.15.x there are other patches to considerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14918 to current stable