Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1042 fix duplicate activities on custom data block #14904

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 29, 2019

Overview

Fixes duplication of the custom data block

Before

Add a custom field set for activities.
Create an activity.
Go to search - find activities.
Click the View action link.
In the popup the custom field set appears twice, once in read mode and once in edit mode.

It doesn't happen when viewing the activity from a contact's activities tab.

After

Only appears once

Technical Details

@demeritcowboy I think your analysis of the cause is spot on - do you want to see if this seems to work for you?

Comments

https://lab.civicrm.org/dev/core/issues/1042

@civibot
Copy link

civibot bot commented Jul 29, 2019

(Standard links)

@civibot civibot bot added the 5.16 label Jul 29, 2019
@demeritcowboy
Copy link
Contributor

I can take a look - thanks.

@demeritcowboy
Copy link
Contributor

Thanks @eileenmcnaughton looks good.

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • Works. Also tested delete and "standalone" activity form.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] Undecided
    • [r-test] PASS

@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy + it's regression so merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants