dev/core#1042 fix duplicate activities on custom data block #14904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes duplication of the custom data block
Before
Add a custom field set for activities.
Create an activity.
Go to search - find activities.
Click the View action link.
In the popup the custom field set appears twice, once in read mode and once in edit mode.
It doesn't happen when viewing the activity from a contact's activities tab.
After
Only appears once
Technical Details
@demeritcowboy I think your analysis of the cause is spot on - do you want to see if this seems to work for you?
Comments
https://lab.civicrm.org/dev/core/issues/1042