Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let optiongroup check crash #14895

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

mattwire
Copy link
Contributor

Overview

If the optiongroup datatype is incorrect the check can fail (I found this when data_type was set to 0 or 1 instead of NULL or a valid value). This PR stops the check from ever being able to crash - which being a check it really shouldn't be doing as it'll hide other, more important checks.

Before

Optiongroup check can crash.

After

Optiongroup check can't crash, can only report back as a check is supposed to do...

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 27, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

makes sense to me - thanks @mattwire

@seamuslee001 seamuslee001 merged commit 64b5ec1 into civicrm:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants