Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [TEST] cleanup on export activity test #14850

Merged
merged 1 commit into from
Jul 20, 2019
Merged

[REF] [TEST] cleanup on export activity test #14850

merged 1 commit into from
Jul 20, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor cleanup on a test

Before

More code, less tested

After

Less code, more tested

Technical Details

Switch to using a helper function - this also makes it easier to see what is tested as we can search by param names

Comments

@civibot
Copy link

civibot bot commented Jul 20, 2019

(Standard links)

@civibot civibot bot added the master label Jul 20, 2019
@colemanw colemanw merged commit 067e4af into civicrm:master Jul 20, 2019
@eileenmcnaughton eileenmcnaughton deleted the test_act branch July 20, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw