Menubar - Improve flexibility & remove hardcoded values

[colemanw]

Overview

Minor tweak to crm.menubar.js to make it less reliant on the presence of a <div id="crm-container"> which may not be present on non-civicrm pages.
Also tweaks the js to remove hardcoded pixel values to work better with theme overrides.

Before

Problems loading on non-civicrm pages.
Hardcoded values interfere with theme overrides.

After

Works better on non-civicrm pages.
Works better with theme overrides to the menu size & breakpoints.

Comments

Fixes https://www.drupal.org/project/civimenu/issues/3068607
Fixes https://lab.civicrm.org/dev/core/issues/1127

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

r-code : Looks much nicer without the magic numbers. 👍

@AkA84, any chance you'll be able to look at this?

[colemanw]

AkA84 tested this & approved it on the gitlab issue. Looks to be merge ready.

[mattwire]

It would be good to see an r-run on Joomla / Wordpress + with mosaico editor before merging to ensure this doesn't cause any regressions there. @vingle @lcdservices @kcristiano Are you able to do any of those checks?

[kcristiano]

@colemanw I am unsure about the 'non-civicrm' is that a Drupal Only thing? In WP the menu looks fine after applying the patch.

I do think the only way to really test this in the wild is to merge it and monitor the 5.17 RC.

[mattwire]

Merging based on @kcristiano comments

[colemanw]

@kcristiano yes there is a drupal module to display the Civi menubar on selected non-civi pages. It wouldn't be hard to create a WP plugin to do the same.

[AkA84]

@colemanw what version is this PR going to be in? 5.16 or later?

[mattwire]

@AkA84 It's in master (so 5.17) but I think it would make sense to backport for 5.16 if @colemanw agrees - as then we have all "theme related" changes in 5.16 including the new theming subsystem. And you can target 5.16 with shoreditch.

[colemanw]

Ok I've opened up a backport PR.