Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Export] remove another confusing parameter #14822

Merged
merged 1 commit into from
Jul 15, 2019
Merged

[REF] [Export] remove another confusing parameter #14822

merged 1 commit into from
Jul 15, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 14, 2019 •
edited
Loading

Overview

Very minor code tidy up

Before

Redundant variable determination

After

Class method used

Technical Details

Test added in recent pr

Comments

@civibot
Copy link

civibot bot commented Jul 14, 2019

(Standard links)

@civibot civibot bot added the master label Jul 14, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw this little one has passed

@colemanw colemanw merged commit d2fcf79 into civicrm:master Jul 15, 2019
@colemanw
Copy link
Member

Merging based on code review & passing tests.

@colemanw colemanw deleted the export branch July 15, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw