Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST][EXPORT] Improve unit test on export. #14793

Merged
merged 2 commits into from
Jul 12, 2019
Merged

[TEST][EXPORT] Improve unit test on export. #14793

merged 2 commits into from
Jul 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This updates the methodology used to test the membership export. I also made it check a bunch more fields while I was at it

Before

Less test cover

After

More test cover

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 11, 2019

(Standard links)

@civibot civibot bot added the master label Jul 11, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the update_test branch 2 times, most recently from 7a5f407 to c248f1b Compare July 11, 2019 10:59
@colemanw
Copy link
Member

test this please

@eileenmcnaughton eileenmcnaughton force-pushed the update_test branch 2 times, most recently from 95b0dbf to f4d16b4 Compare July 11, 2019 20:56
@colemanw
Copy link
Member

Adding MOP based on code review.

@colemanw
Copy link
Member

@eileenmcnaughton

Test Result (1 failure / ±0)
CRM_Export_BAO_ExportTest.testMergeSameAddress

@eileenmcnaughton
[TEST][EXPORT] Improve unit test on export (inc add mergeSameAddress …
c2aec6a 
…test)"

This updates the methodology used to test the membership export. I also made it check a bunch more fields
while I was at it
@eileenmcnaughton
Copy link
Contributor Author

Argh cleanup issues -updated

@eileenmcnaughton eileenmcnaughton merged commit 93b6409 into civicrm:master Jul 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the update_test branch July 12, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw